John Howard

Results 1682 comments of John Howard

Here is an example of us handling it: https://github.com/istio/istio/pull/41238/files. You'll note we had to duplicate some of our controllers entirely. This was only acceptable because it was short lived and...

IMO this type of syntax sugar is best handled by higher level tooling (helm, etc).

I think I understood it the first time and still have the same opinion here. Its not worth the complexity for the gain given the same benefits can be achieved...

IMO this is something where Policy Attachment makes sense, which already has the ability to insert at arbitrary points. I worry we are just re-inventing the same concept in two...

Yes you could even do it at the entire Gateway level

@robscott this is on v1.1.0 now, so ready to go from my POV. BTW, do these get cherrypicked or something or is the docs deploying from `main`?

Now that https://github.com/kubernetes-sigs/gateway-api/pull/3166 is merged I think this is unblocked. Let me know if there are any changes needed.

@robscott can you take another look?

Obviously Istio has this as you noted, so I am in favor of this, but just want to note its a tricky tradeoff of how big we allow. Good for...

I don't mind this in genera,l but a lot of those example annotations ought to be replaced by first class API fields that already exist