John Howard

We use in golangci-lint primarily but I personally use it directly as well (faster) On Mon, Aug 29, 2022, 7:55 PM Loong Dai ***@***.***> wrote: > @howardjohn I am working...

```go package main import ( _ "fmt" _ "io" _ "net/http" _ "os" _ "path/filepath" _ "k8s.io/apimachinery/pkg/runtime/serializer" _ "k8s.io/client-go/kubernetes" // allow out of cluster authentication _ "k8s.io/client-go/plugin/pkg/client/auth" _ "k8s.io/client-go/rest" _...

Or remove `--fix` and it will fail on gci or goimports depending on space exist or not exist

Sorry I think they should just be `.gz`. You can view with `go tool pprof ` regardless of the filename though

Here is the root object: https://github.com/envoyproxy/go-control-plane/blob/master/envoy/config/listener/v3/listener.pb.go (same applies to other types in that repo, just isolating one). At the top we have 'protoc-gen-go', will try to see if there are...

I'm not involved in this repo at all but stumbled upon it, looks like they are seeing similar results - https://github.com/alexshtin/proto-bench/blob/master/README.md I am not sure if this is the same...

You mentioned this earlier but just wanted to verify, we upgrades to 1.4 and used newly generated pb.go files and the regression is gone (it's actually a bit faster). So...

@dsnet https://github.com/istio/istio/pull/24956 is the PR, a benchmark is at the top. Some context on the benchmark, it basically is a fairly high level benchmark that covers our primary hot path,...

> I think we already support that. In `required_pull_request_reviews` > section you can set `require_code_owner_reviews` to `true` and then create the `CODEOWNERS` file. > > https://doc.mergify.io/configuration.html#required-reviews > https://help.github.com/articles/about-codeowners > >...

Thanks for the explanation. I forgot to mention after that image it remains opened which led me to believe there may be some race. Either way not a huge concern...