mergify icon indicating copy to clipboard operation
mergify copied to clipboard

Closing and reopening PR makes mergify continually close it

Open howardjohn opened this issue 5 years ago • 2 comments

Example: https://github.com/istio/istio/pull/15129 2019-25-06_11-14-42

is this intended behavior? It seems maybe a race condition where it sees it is closed and goes to delete the branch, but by then it is already open

howardjohn avatar Jun 25 '19 18:06 howardjohn

There are a few implicit rules on backports, such as deleting the base branch that Mergify has created once the PR is closed.

You closed the PR, so Mergify took action to delete the branch it created, which made GitHub close the PR as you can see in the UI.

There might be a race condition or an event that should have been ignored here as you were fighting with it. I let @sileht comment :)

jd avatar Jun 25 '19 18:06 jd

Thanks for the explanation. I forgot to mention after that image it remains opened which led me to believe there may be some race. Either way not a huge concern since we can just reopen it eventually

howardjohn avatar Jun 25 '19 19:06 howardjohn