Devndra Ghimire

Results 10 comments of Devndra Ghimire

@bmroach Lets do that

> The original code would exit when any of the error occurs and print stack trace. > > 26 added lines later, it still does essentially the same thing but...

> https://centerrandomizedvisualization.streamlit.app/ Wonderful stuff, I'd love to review this πŸŽ–οΈ πŸŽ–οΈ

Since it's WIP, it'd be great to use the pytest, the project intends to use pytest for testing @krishna-parajuli , there is now pytest config as well.

> @krishna-parajuli thank you for taking lead on writing tests but the changes so far seem to be very detailed unit tests. Can we focus on writing tests that test...

> I'd recommend using [loguru](https://github.com/Delgan/loguru) for efficiency and avoiding any bugs on custom implementation. I think Python builtin logging module is quite self sufficient for the current use case and...

Good point; poetry not only brings dep mgmt but also virtual env management, so good to implement this, feel free to add this but do make sure that that the...

> I see a lot of effort being put into this, greatly appreciate it. I had not heard about rye before this, not much into python ecosystem, so a few...

@manisha841, if you could add me to your fork, I could then push changes in a separate branch on your fork or maybe to this branch.

@manisha841 CI should be fixed now; it seems that the coverage is under 80% feel free to make changes