moest-np
fix: error handling for file operations
The code for the function read_tsv and read_prefs doesn't have explicit error handling for file operations. This modification will catch any File error operations, or IOError exceptions that occur when trying to open or read the file, and print an error message.
please review, I have updated my PR accordingly! @sumanashrestha @horrormyth
The original code would exit when any of the error occurs and print stack trace.
26 added lines later, it still does essentially the same thing but with some extra error message which would have been fairly obvious with the exception name.
I am generally for proper error handling but just stating my observation.
The original code would exit when any of the error occurs and print stack trace.
26 added lines later, it still does essentially the same thing but with some extra error message which would have been fairly obvious with the exception name.
I am generally for proper error handling but just stating my observation.
Disagreement: The client/user is not capable of dissecting the exception traceback, those are only for developers who can understand them. So, in any client use case, throwing exceptions to them is a bad idea. The user should be informed nicely about what went wrong regardless of how miserably the system failed. Here, the message is nicely written, and the user will know what went wrong.
