Honnix comments

Results 96 comments of


                                            Honnix

Use PEP593 to support typing of parameters

@adriangb Sorry for replying late. We will take a look at this asap. cc @spotify/dataex

update hive.py

LGTM. Could you please add a test case to cover the change? Thanks for your contribution!

Import config parser into TOML parser

I don't have good understanding of the configuration code, but this PR looks weird to me. Why would TOML parser depend on configparser? If we want a default method, let's...

Import config parser into TOML parser

If I understood correctly, TOML and the Python default config (ConfigParser) are two different ways writing config file, and there is no connection between TOML and ConfigParser. The reason `LuigiConfigParser`...

Import config parser into TOML parser

I have made request for change explicitly, so we can move forward with an alternative solution.

Import config parser into TOML parser

The fix could be as simple as adding: ``` def defaults(self): return {} ```

Import config parser into TOML parser

@mishaker As I commented before, config parser and toml parser are two different things, so inheritance doesn't really make sense. I'm not sure why adding a defaults methods didn't work...

Dynamics is not thread-safe

/remove-lifecycle stale

TypeScript signature of async iterators changed unexpectedly:

FWIW, we are having the same problem.

Try to get lease namespace if unspecified

@csviri I guess we can. :) Strictly speaking it is still more like a feature, but given this small breaking change, shipping it sooner seems to be better.