Use PEP593 to support typing of parameters

Open adriangb opened this issue 3 years ago • 3 comments

This uses PEP593 Annotations to support typing of parameters in a way that will make mypy & co treat the instance variables correctly.

Jun 08 '22 07:06 adriangb

Unrelated to this PR. You may want to change your workflow approval settings in Settings -> General -> Actions to this so that users like me that have never contributed to this repo but are not new to GitHub itself don't require approval.

Jun 08 '22 16:06 adriangb

@honnix I merged in master, tests are passing now. Could you take another look at this?

Aug 30 '22 14:08 adriangb

@adriangb Sorry for replying late. We will take a look at this asap.

cc @spotify/dataex

Sep 05 '22 14:09 honnix

@adriangb why was this closed?

Dec 21 '23 09:12 choucavalier

Because I no longer work at the company that used Luigi and don't have time to push this forward given the pace it was going at. Feel free to take it over.

Dec 21 '23 09:12 adriangb

@adriangb ok thanks!

Dec 21 '23 09:12 choucavalier