Honnix
Honnix
> > @Future-Outlier Thank you for summarizing. This approach looks good to me. > > However I noticed a breaking change (not introduced by this PR). For create operation, it...
@Future-Outlier Thank you for the heads-up. If I understood correctly, this only matters if we deploy the agent service as a pod.
Any plan to get this going? Thanks.
> > Any plan to get this going? Thanks. > > Hi, @honnix Kevin is busy with other issues now. He says he can list some details for me, and...
@dlstadther We will take care of it. Looking at https://github.com/spotify/luigi/pull/3220, it seems we should get that in before dropping a new release.
I think this might not be easy to fix because if I understand correctly, dynamic task definition is not exposed to flyteadmin.
Alternatively, this can be done similarly as https://github.com/bazelbuild/bazel/blob/5d5da86dd7a6ad94e755489e743fdd58c480a116/src/main/starlark/builtins_bzl/common/java/proto/java_proto_library.bzl#L121
FWIW, we applied the following patch and it worked as expected: ```diff diff --git a/java_grpc_library.bzl b/java_grpc_library.bzl index ed9900917..ec11f2453 100644 --- a/java_grpc_library.bzl +++ b/java_grpc_library.bzl @@ -104,13 +104,15 @@ def _java_rpc_library_impl(ctx): )...
@ejona86 It could be the case having a toolchain configured globally to target one Java version, while for proto/grpc to target another version, for compatibility reasons. It could also be...
> Although in that case "the Bazel way" would have a full new toolchain, not just javacopts. Right? Yeah that could be an alternative if `java_grpc_library` could accept a Java...