Honggyu Kim

Results 474 comments of Honggyu Kim

Hi @shpark, thanks for the report. Could you please send a PR by detecting mount point of debugfs? There is a nice example at https://stackoverflow.com/questions/9280759/linux-function-to-get-mount-points. ```c #include #include #include int...

I just worried if `mntent.h` is available in android, but it's included in android bionic as well. https://cs.android.com/android/platform/superproject/+/master:bionic/libc/include/mntent.h;drc=master So we can go ahead with it. @shpark Please send a PR...

Please fix pre-commit and unit test errors.

@dongwooklee96 Your two patches have the same commit message title, but does different tasks. Please update it so that we can understand what the change does.

@dongwooklee96 In addition, the current commit message doesn't explain what the patches do. You can think that the commit message is a letter to code reviewers and future readers. (or...

The current PR still gets crashed when running the following command because `node->nr_calls` being `0`. ``` $ gcc -pg -o t-fork tests/s-fork.c $ uftrace record t-fork $ uftrace tui -f...

Thanks for the update. It works fine now, but please add all to fields pane so that we can select with check box. ![image](https://user-images.githubusercontent.com/19642328/185806193-6b17232b-1a18-40b8-b2ed-8bb7801dc9fc.png) It currently has `TOTAL TIME`, `SELF...

You can have a look at #1270 to customize fields in tui mode.

@dongwooklee96 Sorry for the late reply. I've looked into your work but it's not easy to review because many different changes are mixed into a single commit. As @namhyung asked,...

The name of the root node is the `basename(exename)` as follows. https://github.com/namhyung/uftrace/blob/v0.12/cmds/graph.c#L218