Holt Skinner

Results 164 comments of Holt Skinner

Ok, this is a bit complicated because the Document AI Custom Splitter specifically detected those two `"form1"` entries as separate documents. If we combine them together by default, it could...

Not needed with Gemini Review GitHub Action

> > NOTE: This feature is allowlist only, but is visible in the public documentation and needs samples. The Public SDK does not currently include these methods. > > https://cloud.google.com/generative-ai-app-builder/docs/grounded-gen...

~We aren't adding new samples for Generative AI with Vertex AI SDK, unless the feature only works with the Vertex AI SDK. Closing this PR as #13296 covers this feature...

Note: I think that with https://github.com/googleapis/python-genai/releases/tag/v1.11.0 for the Gen AI SDK, all of the missing features for Model Optimizer were added in. So we might not need this PR for...

Please fix remaining lint errors and spelling errors: https://github.com/GoogleCloudPlatform/generative-ai/actions/runs/10117965823?pr=901

@kristoph I think this is what you are looking for? https://github.com/GoogleCloudPlatform/generative-ai/blob/main/gemini/function-calling/function_calling_data_structures.ipynb @koverholt is the author.

Closing due to inactivity. Please re-open once comments are addressed.

@VJlaxmi Looks like your updates haven't been added to this PR