Martin HS

Results 537 comments of Martin HS

Thanks for the PR. During triage, we decided that we don't really see the value of this PR -- input handling and good errors should be returned by the RPC...

From @fjl > We can add field Last in types.Log > With omitempty) > Clients will also need it, and the type used in subscription is types.Log

I guess this is the part I don't find obvious:> Whenever we set the flag for the next state, we will overwrite the value of these elements.

One remaining thought. So we have 1. one producer routine to feed all the blocks into the tracers 2. `threads` consumer routines, doing tracing. The producer may (now) get stuck...

128 max pending trace-states 8 threads Producer feeds 8 states into the taskCh. One of the consumers is really slow, but 7 of them run along ``` consumer-0: 1 consumer-1:...

If you rebase again, the ubuntu appveyor build failure will be resolved.

The other failure is ``` --- FAIL: TestEth2AssembleBlockWithAnotherBlocksTxs (0.04s) api_test.go:121: invalid number of transactions 0 != 1 ``` If you want to get rid of that error, then :+1: on...

> I started is using geth.service. The logs may be in `journalctl` or `/var/log/syslog` or something. This can't really be debugged/investigated without logs. I wonder if it may be that...

First of all, you should use a more recent version. About 1.10.25: > Geth v1.10.25 is a tiny update to flip the mainnet chain configuration to be post-merge. This disables...

... well, can I ? :green_circle: or :red_circle: ?