Martin HS

Results 537 comments of Martin HS

This seems to work well. With the test-method like this: ```diff diff --git a/internal/ethapi/api.go b/internal/ethapi/api.go index 90322033b9..b90ac5048d 100644 --- a/internal/ethapi/api.go +++ b/internal/ethapi/api.go @@ -2035,3 +2035,10 @@ func toHexSlice(b [][]byte) []string...

> What I don't like about this PR, is that the RPC handler will keep running in case of timeout, because it executes the RPC call on a background goroutine...

Might be related to https://github.com/ethereum/go-ethereum/issues/24724

Thank you for this and #25501. It might be that it will take some time for us to evaluate and address these discrepancies, but hard data and steps to reproduce...

Interesting. A quick glance at geth -- I don't think we'd 'detect' such misbehaving encodings: ```golang case msg.Code == discMsg: // This is the last message. We don't need to...

I agree, this does look a bit odd: ```python >>> g 196000000000 >>> gp 21680 >>> v 24000000000000000 >>> gp*g + v 28249280000000000 >>> b 30313139845072020 >>> b > gp*g...

> Note: the time related tests are flaky on a slower machine, since they rely on the existing auth code, which uses `time.Now`. Maybe we can refactor the existing auth...

I've been eyeing through the logs a bit. I wonder if your IO speed is bad? Also, there's a lot of this: ``` WARN [07-03|18:00:40.413] Unexpected trienode heal packet peer=9f0e8fbf...