go-ethereum
go-ethereum copied to clipboard
node: make generated jwt-secret ga+rw
If geth generates a jwtsecret
file, geth master
makes it 0600
, or -rw------
mode. This PR makes it into 0666
, or -rw-rw-rw-
. The reason is that a lot of setups uses different users for the EL and the CL, due to differing docker image setups. Geth dockerfile, IIRC, runs with least hassle as root
, whereas other dockerfiles might be more "according to best practice", and uses a different user.
Anyway, the idea is that anyone can read it, or modify it.
As for the security implications: it makes geth a tad less 'secure' in a hostile multi-user scenarion, but I'd argue that a validator beacon-geth setup where hostile parties have access to the OS is already pretty much compromised.
Only the security guy... could weaken the permissions of the key file 😄
... well, can I ? :green_circle: or :red_circle: ?
Triage discussion: people were against this. The geth docker container can run as any arbitrary user, the op can decide what user to run it as -- and that's who will be creating the file. It was considered a documentation issue rather than something we should change. Closing
:smiling_face_with_tear: