Hanne Moa

> * Different placeholder text color in "Sources" and "Tags" selectors: > Fixed. Set back to blackish (text-base-content).

> * [ ] Modals have disappeared when clicking on "Update filter"/"Delete filter" This is because clicking on the button no longer fires off a request to the view that...

I thought the code line length was 100 or 120? The IDE-guys like longer line lengths. Nice to have, yes. Needed, no. In the age of type writers, line lengths...

I haven't heard of anyone else customizing as much as you. We could just flag the change very clearly.

Removing explicit `permission_classes` when it is identical to `DEFAULT_PERMISSION_CLASSES` sounds like a good idea. We could also add a howto on how to customize per existing view.

`IsOwner` assumes the model has a foreign key `user` pointing to User on it. It's only used by notificationprofile-views so I'm tempted to move that permission to `argus.notificationprofile.drf.permissions`.

> > We could also add a howto on how to customize per existing view. > > That would also be interesting (as an additional option). How can you customize...

> > from rest_framework.permissions import IsAuthenticated > > from argus.auth.views import CurrentUserView > > from myargus.premssions import NeverOnSunday > > CurrentUserView.permission_classes = [NeverOnSunday, IsAuthenticated] > > I see... I'll keep...

Might be an idea to have a mixin-class that looks for the class attribute `additional_permission_classes` and sets `premission_classes` as `DEFAULT_PERMISSION_CLASSES` + `additional_permission_classes`.

But seriously, we could have an `IsStaff` or `IsMemberOfGroupChthulhu` to make the API less open.