Hanne Moa

Results 288 comments of Hanne Moa

I can do this, though I'd pick between flit or hatchling as I've never used PDM. I could also just convert to setuptools with pyproject.toml. `flit_core` ignores .gitignore, it packs...

Easiest way to do this is probably to have another field on the incident that collects all text in the incident and search in that text. Backend-support needed.

There is support for at least search on description in the new frontend, we just haven't turned it on for sikt.

`( ("Open state"=BOTH AND "Acked"=UNACKED) OR ("Open state"=OPEN AND "Acked"=ACKED) )` is actually `((("Open state"=CLOSED OR "Open state"=OPEN) AND "Acked"=UNACKED) OR ("Open state"=OPEN AND "Acked"=ACKED))` which, simplifying the boolean logic...

`foo=bar` as the tag-format is pretty hardcoded everywhere: validators, etc. Makes GET-parameters very easy also. Multiple tags with the same key is also supported IIRC everwyhere: `tags=foo=bar,foo=xux` in GET-parameters, each...

If we are to support "simplex" tags, what makes sense is the tag being just a key, not a value. Backend-wise, that can be supported by allowing the bits after...

I would have preferred the API to be: ``` { "start_time": "2020-09-01 14:54:42", "source_incident_id": "2", "details_url": "/not-a-real-url", "description": "Something went wrong", "tags": ["host=example-sw.uninett.no", "ipaddr=10.0.0.1"] } ```

More importantly data-model wise, currently, a tag-relation has an owner and a date. ``` class IncidentTagRelation(models.Model): tag = models.ForeignKey(to=Tag, on_delete=models.CASCADE, related_name="incident_tag_relations") incident = models.ForeignKey(to="Incident", on_delete=models.CASCADE, related_name="incident_tag_relations") added_by = models.ForeignKey(to=User, on_delete=models.PROTECT,...