Marcel Hlopko

Results 107 comments of Marcel Hlopko

Hi folks, You're right, https://github.com/bazelbuild/rules_rust/commit/802bcf937dbdffc267d65f4a85cc1c917ac49f63 was created so we have a way to provide those allocator shims to the linker somehow. Internally we use pretty much exactly what you found...

Hi all, small update. Rust rules now pass (simplifying here a bit) `--remap-path-prefix=$PWD=.`. There are some options to debug things: 1. in the root of bazel workspace run `bazel build...

I'm looking into this and I cannot reproduce. Are you compiling your C++ as no-PIC and no-PIE (my testing toolchain uses PIE for C++)?

Yup I was using `-c opt` but my toolchain uses `-fPIE` in opt. It seems yours does not, and that is a problem for rustc when it drives linking (for...

One related thing I may pursue soonish is https://github.com/rust-lang/rust/issues/87934 - that will not help with NOPIC and NOPIE objects, but it will make executables with PIE a bit faster.

I just merged a failing test case for shared libraries (https://github.com/bazelbuild/rules_rust/pull/1141), and https://github.com/bazelbuild/rules_rust/pull/1134 is where we're attempting to fix it. If the issue you're seeing is with `rust_binary` we'll need...

Which suggested approach to use clippy do you use? This one? ``` $ bazel build --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect --output_groups=clippy_checks //hello_lib:all ``` I presume you added this to your .bazelrc as something like:...

So if I understand right - the issue is that rules_rust produce paths that are too long on Windows. We have multiple solutions: 1) decreasing the chance of this being...

CC @c-mita (I hear they're looking into coverage these days :)