Marcel Hlopko

Results 107 comments of Marcel Hlopko

Hi @nlopezgi, the problem with `BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN` was fixed by https://github.com/bazelbuild/bazel/pull/8459. Thanks for reporting! To be explicit - I don't think we need to postpone flipping this flag because of `BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN`...

Drive by - this should be filed in https://github.com/bazelbuild/bazel. It's a Bazel crash. It shouldn't crash :)

Is there a problem you're trying to solve? Right now the `Label` doesn't own its string because it doesn't have to. I expected that the user has a string from...

Thanks @jsgf, that's super useful to know. We will definitely try both approaches and let you know what we found. If I had to guess I'd say that performance-wise both...

I see this PR is still a draft, are we sure @mfarrugi is asking for feedback at this point?

> > Separately, I noticed that this is unnecessarily linking libm and libstdc++, why do we do that? > I'm pretty sure @hlopko introduced this in #562 - I think...

> Is there no fix that can be applied in just the rules..? I wouldn't really consider anything a "fix" that requires the machine to have a specific environment variable...

Could you explain the concrete cases where rustc used incorrect libraries (which C++ toolchain, which library was misused, which library should have been used instead) and which libraries were not...

> I have a collection of custom C++ toolchains I use for one of my projects. These are designed to allow me to do cross compilation to a couple of...