Marcel Hlopko comments

Results 107 comments of


                                            Marcel Hlopko

In Ruby, support each without block on repeated fields

Hi [shaldengeki](https://github.com/shaldengeki), do you plan to make these tests run (and fix them if they need fixing) in this PR, or in a separte one? Should we convert this one...

In Ruby, support each without block on repeated fields

@JasonLunn WDYT?

python: support passing `memoryview` to `bytes` fields

I've just ran the CI and it seems many tests are broken, for example with `TypeError: '

Expose --proto_compiler to Starlark rules

Proto toolchain is something that we will eventually do. Pretty much every user of protobuf shares your concern that recompiling protobuf all the time can slow down the build. We...

rustfmt breaks a `/* ... /` comment into `/ ... //`, with no terminating `*/`

Thanks @ytmimi!

bindgen dependencies aren't setup correctly when using rules_rust with bzlmod

@matts1 is there a chance you'd be interested in fixing this one as well? It seems you know your bzlmod things :) Thanks!!

Remove failure when bindgen cc_lib does not contain static library

Thanks @jwnrt, the PR makes sense. Would you mind adding a separate example in examples/bindgen (for example a header that is used from both Rust and C++, and both libraries...

Expose bindgen toolchain through bzlmod

(just a drive by that this is an exciting change and it would be great to have it merged - thanks @jwnrt and @UebelAndre)

src build on windows not working

@meteorcloudy could you recommend the best solution for us?

src build on windows not working

CC @jskeet, would it be an option to not use `include_prefix` in the C# BUILD files at all?