Hubert Liberacki

Results 23 comments of Hubert Liberacki

https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.

> Now that #959 is merged this PR should update `rclpy/test/test_parameter_client.py` to use the new `spin_until_complete` methods instead of `spin_until_future_complete` I was out of town, I will fix it shortly....

Due to RCLCPP API change https://github.com/ros2/rclcpp/pull/1874.

https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.

Due to change in RCLCPP - https://github.com/ros2/rclcpp/pull/1874 Pull request

@fujitatomoya i will restore all formating base changes, they were due to some formatting plugin in IDE which did it implicitly (i did not check the diff good enough). it...

> LGTM with passing CI > Unfortunately, this CI will most probably fail. This is because it did not include all the related PRs and there will be a missing...

This will be even more complicated in the new API - proposed in #1874 (Accepted, pending for Humble to branch the release out of master). `GuardConditon` would need to also...

Due to changes in RCLCPP, made in https://github.com/ros2/rclcpp/pull/1874 PR.

@audrow https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.