ros2cli icon indicating copy to clipboard operation
ros2cli copied to clipboard

Published 20 hours ago • verified publisher icon ros2

Replace deprecated `spin_until_future_complete`

Open hliberacki opened this issue 2 years ago • 4 comments

Replace deprecated spin_until_future_complete with spin_until_complete

Signed-off-by: Hubert Liberacki [email protected]

hliberacki avatar Mar 31 '22 15:03 hliberacki

Due to RCLCPP API change https://github.com/ros2/rclcpp/pull/1874.

hliberacki avatar Mar 31 '22 15:03 hliberacki

https://github.com/ros2/rclcpp/pull/1874#issuecomment-1086906375 Passing CI with all related PRs linked and build together.

hliberacki avatar Apr 04 '22 13:04 hliberacki

@audrow requesting final review.

fujitatomoya avatar Apr 11 '22 03:04 fujitatomoya

Since this is part of rclpy changes, it's blocked on https://github.com/ros2/rclpy/pull/919#pullrequestreview-1018757431, but is not needed to fix CI after https://github.com/ros2/rclcpp/pull/1874 was merged prematurely.

wjwwood avatar Jun 24 '22 17:06 wjwwood

I've opened #893 to replace this PR.

christophebedard avatar Apr 02 '24 21:04 christophebedard

This can be closed, see https://github.com/ros2/ros2cli/pull/893#issuecomment-2035716089

christophebedard avatar Apr 10 '24 18:04 christophebedard