John Hendrikx

Results 133 comments of John Hendrikx

> Looks good to me. Tested on Windows10 and verified that not setting `observer` to `null` does not lead to any leak. Please merge with latest master to trigger a...

> I would not recommend to make this change as it may break any existing app, even though the app is at wrong to pass `null` Or atleast not to...

> > @andy-goryachev-oracle raises a good point about perhaps wanting to solve this in a similar way for the various places where we need to do some sort of iterative...

> Thank you very much @hjohn for your extensive review. Before addressing your comments, I'd like to get some clarification (ideally also from @kevinrushforth), because I am a bit confused...

I think a single pass algorithm should be possible. The fractional screen scale should make no difference here as you can treat sizes (after scaling when snapping is on) as...

I've put some additional time into this, and I can only conclude that when snapping is on, that every float calculation that is performed (even something as simple as an...

> > I think a single pass algorithm should be possible. > > In some simple cases, yes. But not in all possible cases. > > Let's consider one example,...

> Perhaps i did not emphasized one thing: I believe single pass algorithms would not work when all of the following are true: > > * min/max constraint(s) > *...

> > I'm sorry, I don't quite see what you mean here, perhaps this is unique to the TableView layout. > > It is not unique. The scenario I am...