hius07
hius07
No crash on Kindle. Pinging @pazos for some android ideas.
Thanks, I think it's interesting. Agree that the progress window should be a separate widget. No need to build a mighty TitleBar, it can be just two strings (TextWidgets).
I think the redraw step should depend on a file size. Downloading a small file, no need to redraw five times within 1-2 seconds.
> I'm not sure how I would implement the trapper but I like the the iidea. For example: https://github.com/koreader/koreader/blob/24f1a80ce8571e50356bd970792218f1c118492c/plugins/opds.koplugin/opdsbrowser.lua#L1065-L1070 https://github.com/koreader/koreader/blob/24f1a80ce8571e50356bd970792218f1c118492c/plugins/opds.koplugin/opdsbrowser.lua#L1102-L1111 With standard info message: https://github.com/koreader/koreader/blob/24f1a80ce8571e50356bd970792218f1c118492c/frontend/apps/filemanager/filemanagerfilesearcher.lua#L142-L150
I think the centered content is good. Please order the `require` section (in alphabetical order, case sensitive, see other widgets for example). I'd propose to have the defaults ```Lua local...
I'd prefer this remains a user patch.
> pick the cover of the first book with one in that folder in alphabetical order The fans of this feature would like to see the cover of the first...
> +1 Can you give exact details how to reproduce the bug.
"Sync T/B margins" action in the New profile is the culprit, I'll think how to fix.
Please wait for https://github.com/koreader/koreader/pull/13831, it will help.