hius07

Results 641 comments of hius07

Temporary highlights are drawn by crengine, permanent ones - by the frontend (supporting styles).

The reasons: https://github.com/koreader/koreader/blob/c3352ee171aa8ea695f64518a38c03b759e7cb24/frontend/ui/widget/dictquicklookup.lua#L649-L652

> Maybe flush the settings before running the backup to reflect any changes recently made. https://github.com/koreader/koreader/blob/aa32e019da6b2f3dc8987b1a0840022303f05bf3/frontend/apps/filemanager/filemanager.lua#L1582-L1588

For paths, we can preserve more settings: https://github.com/koreader/koreader/blob/8b13b20713e47f5cad4a18872ca19c6e0123d9dd/frontend/apps/filemanager/filemanager.lua#L1633-L1638 For plugins, isn't the list of disabled plugins dynamic (except manually disabled)? https://github.com/koreader/koreader/blob/08bc71895ad71ae07f8b75aee2a01df9c475e30d/plugins/autosuspend.koplugin/main.lua#L4-L6

I see the following settings related to absolute paths: `download_dir` `clipping_dir` (within Exporter plugin settings) `folder_shortcuts` `home_dir` `inbox_dir` (for Calibre plugin) `screensaver` many paths `screenshot_dir` We can preserve (do not...

Why are you so worried about plugins? Can you give an example of a harmful plugin if fired on an unsupported platform? Looking at the plugin list, I do not...

> See #12770 After restoring the settings from a backup, KOReader is forcibly restarted and unsupported plugins are disabled. Yes, the settings of disabled plugins remain in the settings file....

> $KOREADER is the `koreader` folder That's exactly what we do: https://github.com/koreader/koreader/blob/af1829a27086effc2e3648e223cc88677f5325c5/datastorage.lua#L10

> > I've added a checkbox to preserve paths > > That's good :) But it doesn't solve migration. Paths need to be created if not present on the device....

Yes, History (absolute) paths are not updated. Should they? Do you have the same folder structure of libraries on both devices? EDIT: but the History should not be erased, it...