hius07
hius07
Assuming it's a pdf, I'm afraid it is difficult to fix. To determine the order we compare y (vertical coordinate) of the highlighted boxes. y of 3 is less than...
koreader/settings/profiles.lua
For profiles, it shows the profile name. For gestures, it's not helpful, is shown for consistency, probably may be dropped.
In my opinion the header is not needed for gestures at all. It's just one line in Dispatcher, we can do it in the next visit to it.
https://github.com/koreader/koreader/blob/b8af072d9f1c7c2612e24017ffec65925499c9df/frontend/dispatcher.lua#L1086
Can it be used with other servers than calibre-web? What will happen if a user tries to sync a public OPDS catalog? Will it start downloading thousands of books, unable...
I propose to save sync settings into the OPDS plugin settings file instead of G_reader_settings. So, with some names changing: ```Lua function OPDS:init() self.opds_settings = LuaSettings:open(self.opds_settings_file) if next(self.opds_settings.data) == nil...
Looks nice (haven't looked at the code yet). Maybe add a separator (empty {}) after "Add catalog". Maybe put "Open" at the rightmost position (the most frequent action). For sync...
I propose to enter file types as a string of comma separated types. Empty string - all types (no check). Should it be a per server or a common setting?
Hard to say, I do not sync, but assume that file types per server is more useful (comics from one catalog, epubs from another). But you are right, there is...