Hisham Muhammad

Results 636 comments of Hisham Muhammad

> It looks like the "fallback", where it notices that you used a 3.0 feature but didn't ask for rockspec_version=3.0, is not working for "dependencies". If I take out my...

> I think that would definitely be more user friendly, entirely orthogonal to the URLs issue. I could imagine for example someone getting confused if they try to use namespaces...

> By the way, the new approach is going to make things a little more confusing when/if we try to add git support. Yeah, I've been thinking about that. `file`...

(git support is more forward-thinking stuff, I think — I'd limit the scope of this PR to file:// and http(s):// only — after all today you _can_ do `luarocks install...

> Oh, I didn't populate the namespace field of "query". I left it nil. Is there logic that that is inappropriate for? It won't crash (nil means "no namespace"), but...

> what code is supposed to be reading that namespace back out, once it is placed in the query object `manif.get_versions`. > The failure occurs because in match_dep, "versions" is...

> Also would it be possible to get some assistance with creating a test in the spec/ folder? It seems the tests are done in a particular way. Yeah, the...

Thank you for the report. Which version of Visual Studio are you running? The only thing I can spot that could have to do with this in between 3.1.3 and...

> Looking at the alternatives to luasec transport, curl and wget, it appears that those have certificate validation disabled as well. I believe that for wget and curl transports you...

> Why isn't this on by default? Good question, I don't recall why it was off by default, when the flag was added I think it was kept `false` by...