Hisham Muhammad

Results 636 comments of Hisham Muhammad

@npalladium Yes, this is still open! That logic happens in the `luarocks.repos` module (the logic as a whole is pretty involved, but the bit that does conflict detection happens in...

@npalladium Sounds like a plan! Yes, the backend logic is in `luarocks.repos`, which is triggered by those other modules.

> Given that the wget usage is a fallback anyway, it seems like adjusting luarocks uasge so that it uses the minimum flags possible and is compatible with the busybox...

> The bug is fixed and released on the luasocket side of things Great news! > Luarocks depends on luasec which in turn depends on luasocket You can still install...

(As a bonus, using the Lua dependencies, LuaRocks runs much faster.)

Yay, thanks for taking on this feature! I added some comments.

- I think `source.revision` won't be ambiguous (that's what the table namespacing is for, after all) and is more obvious than "changeset" — every time I saw people asking for...

> If a rockspec is temporary this isn't a big deal, so maybe this is an argument to be more lenient here, and more strict in luarocks.org. This is not...

This was auto-closed by accident when the (now merged) `luarocks-3` branch was deleted. Sorry!

@mcclure So I finally had some time to give this a closer look. I found the cause of that weird failure, and pushed 7037d5e, which makes it not crash anymore...