Hisham Muhammad

Results 633 comments of Hisham Muhammad

No, I'm afraid it doesn't. The `*_done` functions never free the object itself. They free its fields: https://github.com/hishamhm/htop/blob/f1f805f29f6358aafc392c07d3569d143786961e/Process.c#L487-L490

I need to get a better understanding of what's going on. `Process_delete` does `free(this)` in all platforms, it's that's function's responsibility. The stack trace seems to show that `this` is...

@juanfra684 @falsovsky What are the steps to reproduce this bug? Does it crash immediately or after a while? Did you enable something in particular to catch the problem (compiler flags,...

@falsovsky Thanks for the feedback! what is your ~/.config/htop/htoprc?

@mmcco I installed an OpenBSD VM just because of this issue, and I haven't been able to trigger it either. Perhaps it's a version-specific issue? @juanfra684 @falsovsky what versions of...

These crashes seem to be in really random places! The first one looks like `->draw` was set to 1 instead of a valid pointer. The second one looks like a...

Not willing to shift away blame, but if it happens only with OpenBSD 5.9-current, is there a chance this is a bug in some other component? (I assume 5.9-current is...

I just upgraded GCC to 5.3.0, rebuilt htop with `make CFLAGS="-O0 -fsanitize=undefined -fno-sanitize-recover"`. From the get-go, the only problem to get htop running in this mode was this: ``` diff...

@fcambus Thank you! This is useful for investigating! In the cases when it crashes (not with the `Vector_isConsistent` assert), do the backtraces always look like this? (I mean, `strlen` called...

In a heavily loaded system, sometimes the load averages are much higher than the number of CPUs. 100 is too much, indeed, but on the other hand, setting the bar...