hiroshitashir

Results 18 comments of hiroshitashir

I believe this bug is fixed in the current version 3.2.6. In [Fraction.constructor](https://github.com/Uniswap/sdk-core/blob/a322450501ee7dc0e0fa076af3f9758093defcaf/src/entities/fractions/fraction.ts#L28-L31), `numerator` and `denominator` are always initialized. ``` public constructor(numerator: BigintIsh, denominator: BigintIsh = JSBI.BigInt(1)) { this.numerator =...

I found a solution for this, which is to add `chainId` of the network you forked in [hardhat.config.ts](https://github.com/hiroshitash/hardhat-fork-with-ens/commit/f690263f22979941e7fa4d637bf4f17ac3ca2db5). To detect network, `ethers.js` asks for `chainId` [here](https://github.com/ethers-io/ethers.js/blob/33a029e457320a226c68a01f4cfa2d110125a8b8/packages/providers/src.ts/json-rpc-provider.ts#L383). Since hardhat's default chainId...

@fvictorio A [PR](https://github.com/NomicFoundation/hardhat/pull/3947#issuecomment-1557780426) was sent. Please let me know if there is anything I can do on my end:-)

@fvictorio This issue was reproduced in [hardhat-proxy-breaks-regexps](https://github.com/hiroshitash/hardhat-proxy-breaks-regexps) by adding [regExpField](https://github.com/hiroshitash/hardhat-proxy-breaks-regexps/blob/main/hardhat.config.ts#L14). Fix below and tests are added in [PR](https://github.com/NomicFoundation/hardhat/pull/3950). ``` let result = Reflect.get(target, property, receiver); if (result instanceof Function) {...

PR created at https://github.com/NomicFoundation/hardhat/pull/4039.

A separate package was created at https://github.com/hiroshitash/uniswap-sdk-fraction. A [PR](https://github.com/Uniswap/sdk-core/pull/73) for the README was also created. Please let me know with any questions.

Thank you for your suggestion. I will follow your suggestion.