sdk-core icon indicating copy to clipboard operation
sdk-core copied to clipboard

Published 20 hours ago • verified publisher icon Uniswap

Can Fraction be moved to separate package?

Open shrpne opened this issue 4 years ago • 2 comments

I very like Fraction implementation and would like to use it in my project, but for now i have to install whole sdk-core which pulls ethersproject and other unrelated dependencies.

Can it be moved to a separate package?

shrpne avatar Oct 14 '21 11:10 shrpne

Hi @shrpne! Thanks for requesting this, I can definitely see the Fraction package being useful on its own. Given this codebase is licensed under MIT, feel welcome to pull it into a separate package as long as you follow the license guidelines.

If you do so, it'd be great if you submitted a PR to the README here pointing to the separate package for others who might also like the Fraction package on its own.

marktoda avatar Jul 06 '22 20:07 marktoda

A separate package was created at https://github.com/hiroshitash/uniswap-sdk-fraction. A PR for the README was also created.

Please let me know with any questions.

hiroshitashir avatar Jul 13 '23 20:07 hiroshitashir