hiroshitashir

Results 18 comments of hiroshitashir

I tried to reproduce this error with the suggestion from @ivanzhelyazkov at https://github.com/hiroshitash/hardhat-inferred-error, but I wasn't able to. Instead, I receive the following error, which seems correct. ``` % npx...

@devinaconley I found the root cause of your error `library was called directly`. It's because `ERC20CompetitiveRewardModuleInfo` is library (not contract) [here](https://github.com/gysr-io/core/blob/614dfffb97cb136190594849c50b29766341f3cd/contracts/info/ERC20CompetitiveRewardModuleInfo.sol#L23) ``` library ERC20CompetitiveRewardModuleInfo { using GysrUtils for uint256; ```...

@Samboy76 The error message `library was called directly` is hiding your original error so I suggest the followings: 1. Temporarily change `library` to `contract` (in order to hide `library was...

Yes, it could be. The stacktrace is thrown by ether.js [here](https://github.com/ethers-io/ethers.js/blob/ec1b9583039a14a0e0fa15d0a2a6082a2f41cf5b/packages/providers/src.ts/json-rpc-provider.ts#L55). Hardhat should not process the stacktrace message. If we do, we get different error messages depending on deploying on...

I believe [these](https://app.circleci.com/pipelines/github/ethereum/solidity/30308/workflows/f88c02a0-8229-4ef1-af9d-ffaea84fc778/jobs/1345063/parallel-runs/0/steps/0-103) are valid style errors. '*'s should be left-aligned. ``` Coding style error: libsolidity/analysis/ControlFlowBuilder.cpp:587: if (auto const *builtinFunction = m_inlineAssembly->dialect().builtin(_functionCall.functionName.name)) libsolidity/analysis/ControlFlowBuilder.h:155: void placeAndConnectLabel(CFGNode *_node); libsolidity/analysis/TypeChecker.cpp:1556: if (auto const...

Hello @aarlt, Absolutely! I am running the same version of MacOS (Ventura 13.4.1) with `grep (BSD grep, GNU compatible) 2.6.0-FreeBSD`. ``` # default grep on MacOS % grep --version grep...

Hi @aarlt @nikola-matic, I rebased and squashed my old and new changes into one commit. I also made one additional change besides fixing right-aligned '*'s: - `\s` was replaced with...

Hello @aarlt, I just rebased my branch and all tests passing. Let me know if there is anything else I can do.

It looks like package `regenerator-runtime` is installed via package `tsdx`. Both [[email protected]](https://www.npmjs.com/package/regenerator-runtime) and [[email protected]](https://www.npmjs.com/package/tsdx) are latest versions. I wonder if I'm missing something.. ``` % npm ls regenerator-runtime @uniswap/[email protected] /Users/hirotashiro/Uniswap/sdk-core...

`node_modules/regenerator-runtime/runtime.js` has the correct version in my environment. ![Screenshot 2023-07-05 at 12 48 07 PM](https://github.com/Uniswap/v3-sdk/assets/1159921/a9e55a1b-e39b-4e72-80b9-213bc96aa353) It could be something to do with npm as you said. Deleting node_modules folder and...