Oleg Kunitsyn

Results 35 comments of Oleg Kunitsyn

@themoriarti It's the resources for an operator itself, which could be recognized from [the very first line](https://github.com/aenix-io/etcd-operator/blob/eaca8d6006a18a05ffe8dfe7009739261d21b0bd/charts/etcd-operator/values.yaml#L1) of file and [from here](https://github.com/aenix-io/etcd-operator/blob/eaca8d6006a18a05ffe8dfe7009739261d21b0bd/charts/etcd-operator/templates/workload/deployment.yml#L48), not for the node of ETCD cluster. I...

Also, as it could be discovered [here](https://github.com/aenix-io/etcd-operator/blob/c9f9c45c0c4a9694a1b76e75a72ed52c5d0ddc59/internal/controller/factory/statefulset.go#L72-L79) and [here](https://github.com/aenix-io/etcd-operator/blob/c9f9c45c0c4a9694a1b76e75a72ed52c5d0ddc59/internal/controller/factory/statefulset.go#L309-L354) we do not apply any default resources for nodes in ETCD cluster itself. Am I right in saying that you want...

I've found official recommendations from the ETCD [documentation](https://etcd.io/docs/v3.5/op-guide/hardware/), for me it looks a bit fuzzy. I wouldn't implement it taking into account various of ETCD usages in Kubernetes. I prefer...

I am a bit confused with this section of flow: ![image](https://github.com/aenix-io/etcd-operator/assets/114359669/d36310d0-d602-4999-bd21-898279716634) I would suggest a bit updated way to control resources in this case: ![sts-flow](https://github.com/aenix-io/etcd-operator/assets/114359669/d03581ee-2256-473d-a18d-f1aa2dc38ba2)

Also, I didn't get the purpose of the steps: - "Promote any learners." - "Ensure StatefulSet with replicas = max member ordinal + 1" I mean, could you please list...

I would like to vote on this PR, it's really helpful and solves a lot of confusing issues in the current repository state.

I'm just worried about the way how it was implemented. Is it okay in general to have a server in a separate goroutine? If so, I'll proceed with the documentation...

I assume that I've finished all the required changes. Could you please take a look or delegate it to someone? @ncw

Hi, @ncw ! > Is this backwards compatible? By default it should serve the metrics on the rc port 5572 like it has always done. The new HTTP server should...