apisix-docker icon indicating copy to clipboard operation
apisix-docker copied to clipboard

fix: avoid config.yaml modification in standalone mode due to read only file system.

Open TheShubhendra opened this issue 1 year ago • 15 comments

  • Removed modification of config.yaml in standalone mode.
  • Added checks to make sure it uses data plane with yaml config provider.
  • Added separate config file for standalone mode example.

TheShubhendra avatar Jul 22 '24 17:07 TheShubhendra

This PR will close #541 , #547 and #557 .

TheShubhendra avatar Jul 22 '24 17:07 TheShubhendra

Can you please review @kayx23

TheShubhendra avatar Jul 23 '24 06:07 TheShubhendra

the CI is not running, please push an empty commit

shreemaan-abhishek avatar Jul 24 '24 04:07 shreemaan-abhishek

the CI is not running, please push an empty commit

@shreemaan-abhishek I have pushed an empty commit but CI is still not running.

TheShubhendra avatar Jul 24 '24 05:07 TheShubhendra

I had tested workflow apisix dashboard all in one docker on my local system, it works fine after https://github.com/apache/apisix-docker/pull/558/commits/2ef539fa37f176d77a958f8fcaa654fcdd592a4d . So I had modified the workflow file in my fork that shows it is not able to run the container to due to segmentation fault as mentioned in this job run https://github.com/TheShubhendra/apisix-docker/actions/runs/10062135660/job/27813891259 .

TheShubhendra avatar Jul 24 '24 06:07 TheShubhendra

Can someone please review?

TheShubhendra avatar Jul 25 '24 15:07 TheShubhendra

@TheShubhendra, please check why is the dashboard CI failing. Thank you for your patience.

shreemaan-abhishek avatar Aug 04 '24 07:08 shreemaan-abhishek

@TheShubhendra, please check why is the dashboard CI failing. Thank you for your patience.

As I mentioned before, the same workflow works on my PC, but it gives a segmentation fault on GitHub Actions. https://github.com/TheShubhendra/apisix-docker/actions/runs/10062135660/job/27813891259#:~:text=Segmentation%20fault%20(core%20dumped) This could be due to GitHub's resource limits or possibly another issue not related to apisix, I suppose?

TheShubhendra avatar Aug 04 '24 08:08 TheShubhendra

Re-running failed jobs. image

kayx23 avatar Aug 04 '24 14:08 kayx23

Why all actions are now failing with the same reason docker-compose: command not found

TheShubhendra avatar Aug 05 '24 06:08 TheShubhendra

image

This issue seems to be from the main APISIX source code, not this repository.

Edit: My bad it uses local Dockerfile to build

TheShubhendra avatar Aug 05 '24 08:08 TheShubhendra

@TheShubhendra, thanks for the fix. Please make this fix in another PR and then pull changes from master when the fix PR is merged. One PR for one thing. Thanks for your patience.

shreemaan-abhishek avatar Aug 05 '24 13:08 shreemaan-abhishek

@TheShubhendra, please merge master branch to pull the fix.

shreemaan-abhishek avatar Aug 14 '24 04:08 shreemaan-abhishek

can someone please review this PR

TheShubhendra avatar Aug 17 '24 09:08 TheShubhendra

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Oct 16 '24 10:10 github-actions[bot]

Any updates on this?

TheShubhendra avatar Oct 25 '24 04:10 TheShubhendra

I would like to vote on this PR, it's really helpful and solves a lot of confusing issues in the current repository state.

hiddenmarten avatar Dec 08 '24 11:12 hiddenmarten