hhugo
hhugo
@phated, I've identified a change that make every thing slow. https://github.com/ocsigen/js_of_ocaml/pull/1409 You enable backtraces unconditionally in module_resolution. Jsoo will create a js `Error` for every exception raised to capture backtraces....
I've make some cleanup in https://github.com/hhugo/grain/tree/cleanup but it's missing an upgrade to js_of_ocaml-compiler.5.8.2. I don't know how to use esy properly.
I think the issue is that 3rd party libs enable backtraces. See https://github.com/reasonml/reason-native/blob/20b1997b6451d9715dfdbeec86a9d274c7430ed8/src/rely/Util.re#L12 You can try overriding caml_record_backtrace with ```javascript //Provides: caml_record_backtrace function caml_record_backtrace(b){ // caml_record_backtrace_flag = b; return 0;...
Here is what I have locally after tweaking the generated code manually. ``` $ node _esy/default/store/b/grain__s__compiler-dc7bdbee/default/test/test.bc.js Running 45 test suites PASS aliased types PASS abstract types PASS recursive types PASS...
@ospencer, I've just merged https://github.com/ocsigen/js_of_ocaml/pull/1637, would you be able to test js_of_ocaml-compiler master here ? (dropping the compiler/test/hacks.js override)
Many changes on jsoo master lately. Would you be able to test the latest commit of jsoo#master and report ?
Dune doesn't build it seems
CI seems happy in https://github.com/hhugo/grain/actions/runs/11974464203/job/33385597702?pr=2
``` Test Suites: 0 failed, 7 skipped, 36 passed, 43 total Tests: 0 failed, 385 skipped, 741 passed, 1126 total Time: 338.145s ```
I'm now seeing the following result locally, using #2210 ``` Test Suites: 0 failed, 8 skipped, 37 passed, 45 total Tests: 0 failed, 405 skipped, 784 passed, 1189 total Time:...