hhugo
hhugo
What's the status of this ?
@OlivierNicole, what should we do we this PR ?
We have the rev version in bytecomp/bytepackager.ml ```ocaml let rec rev_append_map f l rest = match l with | [] -> rest | x :: xs -> rev_append_map f xs...
Try with this diff ```diff diff --git a/compiler/test/dune b/compiler/test/dune index a8b92d0c..111938bc 100644 --- a/compiler/test/dune +++ b/compiler/test/dune @@ -22,4 +22,4 @@ (libraries grain grain-tests.framework grain-tests.suites grain-tests.utils) (modules test) (js_of_ocaml - (flags...
I'm wondering if the slowdown could be due to `yojson reading "cmi"` pattern
The current implementation: - first read the `cmi` section into some `bytes` - convert `bytes` to `string` - `Yojson.from_string` convert the `string` back into `bytes` An alternative approach can mitigate...
> Thanks @hhugo! I've cherry-picked that commit into this branch to see it in action. Any idea why this issue is only showing up now (with this upgrade)? js_of_ocaml-compiler.5.1.0 changed...
With the commit, you no longer need to disable `use-js-string`. I've created a branch with additional changes. see https://github.com/hhugo/grain/tree/hhugo-jsoo-oom
@phated, would you be able to rebase this branch, I have some time to look at this again.