hhugo
hhugo
> > @vouillon, we currently can't distinguish makeblock from makearray at the bytecode level. Should we have a hint for that ? > > I'm not sure what we could...
> > > We could use an hint to distinguish "int comparison" and "physical equality". Or we could use a different bytecode instruction. > > > > > > That...
@OlivierNicole, do you want to take a look at this ?
@rickyvetter, would you be able to test this PR ?
> Ok I understand, in the end, it’s fine because it never results in adding lines in the middle of a file, but this mechanism (that sometimes add a `//#...
@OlivierNicole, may I request another round of review ?
First note that `joo_global_object` should be avoided, support will be removed at some point. One should use `globalThis` instead. It seems to me that vscode-ocaml-platform is part of the problem...
https://ocsigen.org/js_of_ocaml/latest/manual/linker gives some information. In short, ```javascript //Provides: customAdd function customAdd(a,b){ return a + b } ``` ```ocaml external add : int -> int -> int = "customAdd"
I've worked on a bunch of changes to limit global side effects (#1708, #1696) Assuming bindings are written correctly (not by mutating the global object), two jsoo programs should be...
I'm opening https://github.com/ocamllabs/vscode-ocaml-platform/issues/1617 and will close this one