Hernan Romer

Results 25 comments of Hernan Romer

I don't think the build failure is related to my change

I'm working on adding a test at the moment that will sanity check the scanner counts

@Apache9 I'd appreciate any feedback or comments if you have some time!

No rush, I think @ndimiduk is also available next week

@rmdmattingly @ndimiduk @charlesconnell @sidkhillon @krconv

> Another option, which is simpler to reason about, is to simply fail the `SnapshotProcedure` if the table isn't in a state it can handle. This was my approach in...

> > Enabling/disabling tables happens often enough that it might be fine to simply fail and force the user to manually handle the failure. > > Do you mean "happens...

going to proceed with the strategy of simply failing

> When implementing this SnapshotProcedure, we decided to use shared lock and holdLock = true to prevent other table procedure jumps in in the middle of our execution while not...

> > > When implementing this SnapshotProcedure, we decided to use shared lock and holdLock = true to prevent other table procedure jumps in in the middle of our execution...