Hernan Romer comments

Results 25 comments of


                                            Hernan Romer

HBASE-29386: SnapshotProcedure and EnableTableProcedure can cause a deadlock

> > This is certainly a cleaner implementation, though it means we can interleave other table procedures after cycles of the SnapshotProcedure. > > FWIW, if a SnapshotProcedure starts, no...

HBASE-29386: SnapshotProcedure and EnableTableProcedure can cause a deadlock

> TestSnapshotProcedureRIT.testTableInMergeWhileTakingSnapshot failed, I guess this is related to our changes here? Yes must be related I am taking a look

HBASE-29268: Restoring to original splits will fail for remote file systems not on the RS classpath

This should be covered by existing unit tests, as the underlying behavior shouldn't have changed

HBASE-29240: Backup ancestry trees should have the ability to be invalidated

cc @rmdmattingly @ndimiduk @DieterDP-ng

HBASE-29240: Backup ancestry trees should have the ability to be invalidated

Taking a look at javac issues + unit test failures *edit - done*

HBASE-29240: Backup ancestry trees should have the ability to be invalidated

@DieterDP-ng I think I've addressed all your comments here, please let me know if there's anything else you think needs addressing

HBASE-28903: Incremental backup test missing explicit test for bulkloads

cc @rmdmattingly

HBASE-28903: Incremental backup test missing explicit test for bulkloads

cc @DieterDP-ng going to tag you here as well :)

HBASE-29541 Removing unnecessary sanitization in throttle metrics

This looks good to me, cc @rmdmattingly @charlesconnell, any chance you could take a look at this? For context, we don't do this type of sanitation anywhere else in the...

HBASE-29744: Data loss scenario for WAL files belonging to RS added between backups

cc @rmdmattingly @ndimiduk @DieterDP-ng @krconv