Himanshu Gohel

Results 21 comments of Himanshu Gohel

@Nick-Hall Right, there are new strings. However, my understanding was that the new *_HELP strings contain part of a URL and wouldn't be translated. @emyoulation is that the intended usage?

Got it. Did not know that URLs were translated. Thanks for clarifying. Lmk if this needs to be rebased to another branch.

@Nick-Hall > I'm not sure that I like 8000 lines of code defining a list. > Where does the data come from? How do we maintain it? Agreed! Git history...

> If you're open to a new dependency, [`pycountry`](https://pypi.org/project/pycountry/) provides many of these ISO data sets. PyCountry looks good, although there is a [concern about lack of commits in the...

@Nick-Hall > Only issue I'm having is getting the app to find `iso-639-3.tab`. I placed it in data/iso-639-3.tab and was expecting the build process to copy it to resources directory...

> macOS, at least in the AIO bundle, isn't affected by the bug and this change is harmless. Thanks for reviewing the change.

@Nick-Hall Returning to this defect after a while. Discovered a related bug while trying out safe mode, which affects the testing of this one so I think it needs to...

@Nick-Hall Turns out that this defect is a side-effect of [13300](https://gramps-project.org/bugs/view.php?id=13300), and the fix for that is in PR #1726 (gramps52) and PR #1725 (master). I'm closing this PR in...

> Still needs Lint fixes Done with commit a68f57c297753a85c2da10b64114d30774982e9c

> A revised version of the form is at /World%20War%20II%20Draft%20Registration%20Card. If someone/anyone/everyone could take a look at it and make suggestions to improve it would be helpful. @Caulley Could you...