addons-source
addons-source copied to clipboard
gramps-project
Update WWII draft registration fields
This Form need a complete re-wright. When I created this form I was under the impression that there was only 1 card. There were 6 cards. The form need to be rewritten in a nondestructive manure.
A revised version of the form is at /World%20War%20II%20Draft%20Registration%20Card. If someone/anyone/everyone could take a look at it and make suggestions to improve it would be helpful.
A revised version of the form is at /World%20War%20II%20Draft%20Registration%20Card. If someone/anyone/everyone could take a look at it and make suggestions to improve it would be helpful.
@Caulley Could you provide a full link to the form? Thanks. [Update] Perhaps you're referring to the form that contains the changes in this PR? i.e. the form starting at line 7815?
Link to the form https://github.com/Caulley/Gramps-form_us/blob/main/World%20War%20II%20Draft%20Registration%20Card#L1
I am confused by this change.
First, it is against master branch. It should be against gramps52.
Second, the differences in the PR includes one field Place of employment or business (Address), so breaks existing forms. BUT this change is not consistent with gramps52 branch. gramps52 has the (Address) portion of the field name.
Third, when I use the form provided in the previous Comment, it appears to not break existing form entries. So that specific form change seems okay.
What I see is some additional fields (citizenship, occupation, ...) . I don't have any real examples using these new fields, so I cannot confirm that the update matches all of the WW2 DRC forms. All of my examples use the simple form that is in the original Form layout.
I think this PR needs to be closed and reopened against gramps52 and use the form_us.xml which would include the revised WW2DRC portion. Then we can test it for merging.
Examples of the draft cards can be found here - https://drive.google.com/drive/folders/1h2h23yhgT6V1Do6vqcGMqr2FvcoA0KA7?usp=drive_link