hfig

Results 16 comments of hfig

8.2 is not 8.0. 8.2 is where ``#[\ReturnTypeWillChange]`` starts to bite and managing a library compatible with PHP 7 and 8 becomes a bit more work. I'm happy to take...

No, as it's not a fix. It plasters over an error in the parser. No one's dug into what about it is wrong. As I said in the issue, step...

Something similar has been reported before. What generates the .msg file originally? Can you share an example of a file which trips up the library? Note though that your error...

I think you're misunderstanding the nature of dependencies. This library _depends_ on the third party library ``pear/ole``. It uses ``pear/ole`` to do the mechanical part of parsing an OLE compound...

So, from memory, a MAPI attachment isn't stored as an attachment, it's stored as another sub-document in the OLE compound document. Other types of OLE compound documents - .DOC, .XLS...

The code in Ruby looks like this: ```ruby props = props_obj.read.scan(/.{8}/mn).map do |str| flags, offset = str[4..-1].unpack 'v2' # the property will be serialised as this pseudo property, mapping it...

I ... don't like this. You're swallowing all errors, expected or otherwise. I think the idea, overall, is reasonable -- MAPI to Mime is an imperfect translation and so the...

I don't have a problem with it not throwing and with the conversion being lossy, but it needs to indicate to the caller that the conversion completed only partly. And,...

This is OK mostly. Thanks for your work. But I do have a quibble mucking with the interface by introducing an optional parameter. I think a reasonable fix would be...

hmm it took me a while to understand what you're saying here because your PR doesn't currently include that functionality (passing the flag through so that it would apply to...