MAPI icon indicating copy to clipboard operation
MAPI copied to clipboard

Skip undefined array key

Open luhmannAlexander opened this issue 2 years ago • 4 comments

Hi,

This is a bugfix for issuse 26

I test it by hand and by Uni-Test

Time: 00:00.411, Memory: 12.00 MB

OK (3 tests, 14 assertions)

luhmannAlexander avatar Jun 08 '22 06:06 luhmannAlexander

works great! please push this!

strtob avatar Jun 18 '22 22:06 strtob

I've tested the fix by @luhmannAlexander and it works like a charm!, thank you!

strtob avatar Jun 19 '22 10:06 strtob

But it's not merged ?

Erwane avatar Dec 13 '22 08:12 Erwane

No, as it's not a fix. It plasters over an error in the parser. No one's dug into what about it is wrong.

As I said in the issue, step 1: "verify the code is parsing the file as per the standard".

It may be the is code fine, but doesn't handle the case where the .msg file has attachments that are themselves OLE compound documents. Those attachments' named properties are stored together what those for the email - see https://learn.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-oxmsg/193c169b-0628-4392-aa51-83009be7d71f

But some verification is needed.

hfig avatar Dec 14 '22 09:12 hfig