Stojan Dimitrovski

Results 198 comments of Stojan Dimitrovski

Maybe use rdiscount or bluecloth, instead of redcarpet until the code gets fixed? (That's what I did to the source.)

Tests are failing because conditional `undef DUK_USE_JX` is not possible. The configuration tools read the undef but not the `elif defined(DUK_F_INTELSGX)` surrounding it.

Here are some possible solutions to the problem: 1. Change reading and formatting pointers to functions for that purpose: ```c #define DUK_PTR2STR(buf,sz,ptr) DUK_SNPRINTF(buf,sz,"%p",ptr) #define DUK_STR2PTR(buf,sz,ptr) DUK_SSCANF(buf,"%p",ptr) ``` Then these can...

I decided to add a new option `DUK_USE_STANDARDIZED_POINTER_ENCODING` which when enabled will encode pointers in a "standard" way, i.e. read the pointer value as it is laid out in memory...

Yes, ready for comments @svaarala. I agree on the point for `DUK_F_INTELSGX` and will produce changes toward that approach this weekend.

@svaarala Thanks for reviewing. I tried to get all indent issues, but not sure how I missed these. Maybe think about setting up `clang-format` to get rid of issues like...

What's the ideal style for `void**`? :sweat_smile: Is it `void* *`?

Still many broken indents. Something is wrong with my vim, it's confused by this codebase.

Also a good idea is to add `.editorconfig` since this codebase uses tabs (and I prefer spaces, but that is irrelevant). My vim struggled a bit, so I did a...

Hey @svaarala I finally managed to fix all outstanding issues. Would you mind checking the logic I used in the unresolved comments before merging? TODOs post PR: 1. https://github.com/svaarala/duktape/pull/2219#discussion_r373690188