Stojan Dimitrovski comments

Results 198 comments of


                                            Stojan Dimitrovski

sendOtp function in GoTrueAdmin.ts

So, you're looking for invite over SMS?

No way to display cusom error messages

Please avoid using `instanceof` for checking errors. Use `isAuthError` and other helper functions in such cases.

Updating & refreshing user metadata causes Error "Invalid Refresh Token: Already Used"

This feels like an issue for another repo. `gotrue-js` does not define a `useUser` hook. @silentworks where is this defined?

fix: `_recoverAndRefresh` code efficiency and tidy up

I'm afraid we can't touch the events too much as they are an API contract. The event must remain, however inconvenient or inefficient. As for the rest of the changes,...

Supabase operations in onAuthStateChange will cause the next call to supabase anywhere else in the code to not return.

@izhan What "environment" is your code running in -- what browser (did you try others?), what framework, what TypeScript targets...? We generally expect to see issues reproduced with the latest...

Supabase operations in onAuthStateChange will cause the next call to supabase anywhere else in the code to not return.

> This should be documented in the docs and fixed or addressed as soon as possible. It is a multi-hour loss of time for users trying to figure out and/or...

Supabase operations in onAuthStateChange will cause the next call to supabase anywhere else in the code to not return.

Docs changes here: https://github.com/supabase/supabase/pull/19902

feat: Notify when refresh token fails

This would be the SIGNED_OUT event, no?

Refreshing session can result in duplicate cookies (chunked and non chunked versions)

This is one of the main issues we identified and this discussion explains what we're doing about it: https://github.com/orgs/supabase/discussions/27037 Linking the PR just for reference: https://github.com/supabase/ssr/pull/1

the cookies option doesn't seem to be doing anything

This is expected. `createServer/BrowserClient` implement their own storage option. So if you already set your own, your custom option (`AsyncStorage`) wins.