Zhangjian He

Results 192 comments of Zhangjian He

I think we can simply modify the access modifiers, and mark `@VisableForTesting` .We have used this in many codes.

@tisonkun Yes, I suggest to replace powermock. Using `@VisableForTesting` instead of reflections

can you just update guava library version to latest?

@cjdxhjj could please share the detail error msg or your depnendecy tree? :)

Sorry for my late reply, I don't think spring remove guava for this reason, could you prove that? Spring update many dependencies frequently. Like bytebuddy/netty/prometheus-client. Since you can't update guava...

community has been discussed it before. you can share your feature request on https://github.com/apolloconfig/apollo/discussions/4369 If you are in a hurry, you can manually shade apollo package yourself. cc @nobodyiam

@jcchavezs Thanks for your reply. I don't think I can do the job. I'm not familiar with zipkin and haven't had enough time lately :)

@jcchavezs I have created #3467 trying to fix this. waiting for your opinion. Thanks

> To control a message if acked ? Yes, like if custom logic failed, don't ack :)

> you mean sync publish message to mq? yes.