[FR] Support of junit5 engine

[shoothzj]

Feature

Now zipkin provides zipkin-junit module, it's very useful in tests. However, it only works with junit4, I hope it can support junit5 too.

Rationale

This feature benefits all junit5 users.

Example Scenario

People who using junit5 and want to use zipkin-test module

[jcchavezs]

Up for a PR?

On Wed, 27 Jul 2022, 02:41 ZhangJian He, @.***> wrote:

Feature

Now zipkin provides zipkin-junit module, it's very useful in tests. However, it only works with junit4, I hope it can support junit5 too. Rationale

This feature benefits all junit5 users. Example Scenario

People who using junit5 and want to use zipkin-test module

— Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin/issues/3466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYAXE5XDGL5ASQ7LZYBTVWCAUXANCNFSM54XY3H6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[shoothzj]

@jcchavezs Thanks for your reply. I don't think I can do the job. I'm not familiar with zipkin and haven't had enough time lately :)

[shoothzj]

@jcchavezs I have created #3467 trying to fix this. waiting for your opinion. Thanks

[jcchavezs]

I am OOO. @llinder could you please have a look?

On Sun, 31 Jul 2022, 18:06 ZhangJian He, @.***> wrote:

@jcchavezs https://github.com/jcchavezs I have created #3467 https://github.com/openzipkin/zipkin/pull/3467 trying to fix this. waiting for your opinion. Thanks

— Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin/issues/3466#issuecomment-1200453017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYASCOXSCERVIY7B3LA3VW2QADANCNFSM54XY3H6A . You are receiving this because you were mentioned.Message ID: @.***>

[shoothzj]

closed by #3467