Hesham Massoud

Client decorator for appending custom request headers

12

### Description As mentioned in a previous issues: #1602 It would be great to be able to add additional user- specified headers to the sphere client that it could append...

There are some reference expansion paths that are not supported by the Query DSL from the JVM SDK yet: - `state` - and custom types: - on prices: - `masterData.staged.masterVariant.prices[*].custom.type`...

QueryAllImpl uses offset-based pagination

1

[QueryAllImpl](https://github.com/commercetools/commercetools-jvm-sdk/blob/master/commercetools-convenience/src/main/java/io/sphere/sdk/queries/QueryAllImpl.java) uses an offset based pagination for fetching all products which is against what is recommended by the docs: http://dev.commercetools.com/http-api.html#offset This offset-based pagination does not work with resources more than...

In the `AttributeImpl` there is the method `getValue` that takes `AttributeAccess` access to return you a value of type `T.` For example, it can be used to return a value...

Include lastSyncStatistics in LastSyncCustomObject#equals comparison Depends on https://github.com/commercetools/commercetools-sync-java/issues/376.

**Situation** Currently on concurrency modification exceptions the sync retries with no limit until there is no error. See: https://github.com/commercetools/commercetools-sync-java/blob/7cacc37ef8a1412f9bf300ba08000c108db81b4f/src/main/java/com/commercetools/sync/commons/BaseSync.java#L115-L124 **Complication** It causes unnecessary api calls if the platform returns 409...

Sometimes logs are printed not where they should be. As seen here for example: 1. https://travis-ci.org/commercetools/commercetools-sync-java/builds/274153150#L907 2. https://travis-ci.org/commercetools/commercetools-sync-java/builds/274152803#L744

Handle client cancellation

1

@yidongnan Is there a way to handle client cancellation interrupts? I would like to stop the execution of the grpc call on the server side, whenever the client cancels the...

must be non-null but is marked as nullable with StringUtils.isBlank() check

6

I am currently getting this error: [` must be non-null but is marked as nullable`](https://travis-ci.org/commercetools/commercetools-sync-java/builds/329381009#L556) Because of the `handleResourceCreation` here: ````java @Nonnull CompletionStage applyCallbackAndCreate( @Nonnull final V resourceDraft, @Nullable final...