Hesham Massoud

Results 8 comments of Hesham Massoud

@katmatt > Basically you are suggesting to avoid using our solution info service because you're afraid that someone might use multiple solution info enabled jars in a fat jar 😉...

@andrii-kovalenko-ct We could also have it in a way that is not as strict as 3 but also flexible in way that doesn't allow the users to remove the default...

@andrii-kovalenko-ct ah ok, if you meant that, then yes 😊 The `.withHeaders(createExtraHttpHeaders())` made it seem that it overwrites the previously set headers. Like the difference between `.withPredicates` and `.addPredicates` in...

Using the `super.httpRequestIntent().plusHeader("foo", "bar");` in https://github.com/commercetools/commercetools-jvm-sdk/issues/1691#issuecomment-365202896 actually would add a `` entry to the list of `NameValuePair`s even if there is a `NameValuePair` with the same key already existing e.g....

Hmm, ok. Thanks for your reply. Unfortunately, this means that decorating the request won't help in changing the headers because in the decorator the headers are not "yet" attached to...

Just for information: We would have a problem with the name of our module `sdk-http-ahc-2_0`, due to the underscore to be able to identify it as an automatic module name...

> At some point external data (CTP project, CSV, XML...) changes to: `Product with key 4: sku 1, sku 2, sku 3` At this point it is important to know...

Depends on finalisation of https://github.com/commercetools/commercetools-node-variant-reassignment