Herman Lee

Results 7 comments of Herman Lee

Thanks for filing the issue. The read filtering functionality is meant present a consistent view of row data across indexes in a table with TTL enabled. If it's disabled, then...

Referencing issue #1024 is sufficient for the TTL bug. I believe we understand issue at hand, that filtering checks is not applied during ha_rocksdb::check_and_lock_sk(). It should be applied in a...

I ran my tests with the range locking change based on top of: https://github.com/facebook/mysql-5.6/commit/b22013dba3a9f0d242004f71bcac4427c7249abb. In your lock outputs, none of the locks look like they were escalated and merged together....

Ah, my setup also inherited these settings from an existing test: -rocksdb_use_range_locking=1 --rocksdb_max_lock_memory=1024

Removing the check should be okay too. The check looks to be inherited from RocksDB cmake files. @spetrunia, I assume none of your builds actually fail with your updated cmake...

Thank you for the PR to fix this issue!

The feature is not on our roadmap since it is not used by most of our applications.