mysql-5.6 icon indicating copy to clipboard operation
mysql-5.6 copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Issue #904: Crash in rocksdb::IOStatsContext::Reset, this=NULL

Open spetrunia opened this issue 6 years ago • 2 comments

Fix both code paths:

  • Change the test source code so it doesn't cause the "Unused variable" warning (which -Werror converted into error and caused CMake not to set HAVE_THREAD_LOCAL)

  • If the system doesn't seem to support HAVE_THREAD_LOCAL, refuse to compile (rather than producing a binary that crashes for some tests)

spetrunia avatar Nov 19 '18 15:11 spetrunia

C++11 thread_local seems to be fully supported starting with GCC 4.8, clang 3.3, MSVC 2015 - maybe that's good enough to switch to thread_local and drop CMake checks altogether?

laurynas-biveinis avatar Nov 20 '18 06:11 laurynas-biveinis

Removing the check should be okay too. The check looks to be inherited from RocksDB cmake files. @spetrunia, I assume none of your builds actually fail with your updated cmake check and thread local is supported across all builds?

hermanlee avatar Nov 21 '18 04:11 hermanlee