Henry Schreiner

I'm looking at https://github.com/tomerfiliba/plumbum/runs/5141354158?check_suite_focus=true Ahhh! That version number is broken on master. Sorry for the noise! I hate "try not to break things" defaults... (I think it works on releases,...

Yeah, fix in #591 - checkout@v2 does shallow clones, unlike v1, and this seems to have been using v2 but assuming v1. It was probably not noticed because releases are...

You also need `requires`: ```toml [build-system] build-backend = "setuptools.build_meta" requires = ["setuptools"] ``` Otherwise you might not get setuptools in the isolated build environment.

For a quick possible fix, you can try using `build[virtualenv]` when you install build - that will use a modern, up-to-date copy of pip. Another option is to use `-n`...

You need the Internet to get packages to set up the isolated virtual environment, which is the default. If you want to manually install all of the build dependencies for...

Great! @hoodmane, pyodide-build might need to adapt after the next release.

Not as a _required_ dep (see #470 and similar discussions, we are keeping required deps to a minimum).

FYI, the wheel pulls the LICENSE file via a name-based search: https://github.com/pypa/flit/blob/ee17c70cdef4c9bd2f1d076f2dd8aacabdd38098/flit_core/flit_core/wheel.py#L185. It seems like the default SDist file inclusion should respect this too by including the same pattern. It...

That's great to hear! For other build backends (scikit-build-core, meson-python, etc), this bug will likely be problematic, and would be good to fix. For example, in scikit-build-core, every config option...

Oh, okay. Is there a path forward for setuptools to fix this? (like egg_info ignoring options it doesn't support, or setuptool's get_requires_for_build_wheel stripping options it doesn't support) It really is...